Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46684: Add Metrics to calibrateImage task metadata #994

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jrmullaney
Copy link
Contributor

No description provided.

@jrmullaney jrmullaney changed the title DM-46684: Add metrics to metadata DM-46684: Add metrics various tasks' metadata Oct 15, 2024
@jrmullaney jrmullaney changed the title DM-46684: Add metrics various tasks' metadata DM-46684: Add metrics various tasks metadata Oct 15, 2024
@jrmullaney jrmullaney changed the title DM-46684: Add metrics various tasks metadata DM-46684: Add Metrics to calibrateImage task metadata Oct 15, 2024
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some suggestions for you to consider.

python/lsst/pipe/tasks/calibrateImage.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/repair.py Outdated Show resolved Hide resolved
@jrmullaney jrmullaney force-pushed the tickets/DM-46684 branch 2 times, most recently from fa2e556 to 3762c44 Compare October 17, 2024 14:40
Metrics added to record a series of quantities in
calibrateImage.py, the number of cosmic rays in repair.py,
and the number of interpolated pixels in interpImage.py.
For consistency, change recordFlaggedPixelFractions
to recordMaskedPixelFractions.
@jrmullaney jrmullaney merged commit 27da71f into main Oct 18, 2024
2 checks passed
@jrmullaney jrmullaney deleted the tickets/DM-46684 branch October 18, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants