Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliyum SMS API #583

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Aliyum SMS API #583

wants to merge 3 commits into from

Conversation

ilanni2460
Copy link

add aliyum sms

@coudot coudot added this to the 1.6.0 milestone May 12, 2023
@coudot
Copy link
Member

coudot commented May 12, 2023

Hello @ilanni2460

You should not push all composer dependencies in code.

See example of OVH API: https://self-service-password.readthedocs.io/en/latest/sms_api.html#ovh

We have a composer file in the lib/ folder, and run composer in it when needed.

Could you update your PR to conform to this?

@coudot coudot self-requested a review May 12, 2023 10:08
@coudot coudot changed the title add aliyum sms Aliyum SMS API May 12, 2023
@coudot coudot added the feedback required Waiting for a feedback label Feb 3, 2024
@coudot coudot self-assigned this Mar 7, 2024
@coudot coudot modified the milestones: 1.6.0, Backlog Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feedback required Waiting for a feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants