Refactor checks of raw directory

disdrodb/l0/l0_processing.py

@@ -818,7 +818,6 @@ def run_l0b_concat(processed_dir, station_name, remove=False, verbose=False):
     if n_files == 1:
         msg = f"Only a single file is available for concatenation in {l0b_dir_path}."
         log_warning(logger=logger, msg=msg, verbose=verbose)
-        raise ValueError(msg)
 
     # -------------------------------------------------------------------------.
     # Concatenate the files

disdrodb/l0/routines.py

@@ -506,7 +506,7 @@ def run_disdrodb_l0(
 ):
     """Run the L0 processing of DISDRODB stations.
 
-    This function enable to launch the processing of many DISDRODB stations with a single command.
+    This function allows to launch the processing of many DISDRODB stations with a single command.
     From the list of all available DISDRODB stations, it runs the processing of the
     stations matching the provided data_sources, campaign_names and station_names.
 
@@ -618,7 +618,7 @@ def run_disdrodb_l0a(
 ):
     """Run the L0A processing of DISDRODB stations.
 
-    This function enable to launch the processing of many DISDRODB stations with a single command.
+    This function allows to launch the processing of many DISDRODB stations with a single command.
     From the list of all available DISDRODB stations, it runs the processing of the
     stations matching the provided data_sources, campaign_names and station_names.
 

disdrodb/l0/scripts/disdrodb_run_l0.py

@@ -53,7 +53,7 @@ def disdrodb_run_l0(
     """
     Run the L0 processing of DISDRODB stations.
 
-    This function enable to launch the processing of many DISDRODB stations with a single command.
+    This function allows to launch the processing of many DISDRODB stations with a single command.
     From the list of all available DISDRODB stations, it runs the processing of the
     stations matching the provided data_sources, campaign_names and station_names.
 

disdrodb/l0/scripts/disdrodb_run_l0a.py

@@ -46,7 +46,7 @@ def disdrodb_run_l0a(
     """
     Run the L0A processing of DISDRODB stations.
 
-    This function enable to launch the processing of many DISDRODB stations with a single command.
+    This function allows to launch the processing of many DISDRODB stations with a single command.
     From the list of all available DISDRODB stations, it runs the processing
     of the stations matching the provided data_sources, campaign_names and station_names.
 

disdrodb/l0/scripts/disdrodb_run_l0b.py

@@ -46,7 +46,7 @@ def disdrodb_run_l0b(
     """
     Run the L0B processing of DISDRODB stations.
 
-    This function enable to launch the processing of many DISDRODB stations with a single command.
+    This function allows to launch the processing of many DISDRODB stations with a single command.
     From the list of all available DISDRODB stations, it runs the processing of the
     stations matching the provided data_sources, campaign_names and station_names.
 

disdrodb/l0/scripts/disdrodb_run_l0b_concat.py

@@ -38,7 +38,7 @@ def disdrodb_run_l0b_concat(
 ):
     """Run the L0B concatenation of available DISDRODB stations.
 
-    This function enable to launch the processing of many DISDRODB stations with a single command.
+    This function allow to launch the processing of many DISDRODB stations with a single command.
     From the list of all available DISDRODB stations, it runs the processing of the
     stations matching the provided data_sources, campaign_names and station_names.
 
@@ -84,4 +84,3 @@ def disdrodb_run_l0b_concat(
         remove_l0b=remove_l0b,
         verbose=verbose,
     )
-

disdrodb/metadata/scripts/disdrodb_check_metadata_archive.py

@@ -24,7 +24,9 @@
 
 @click.command()
 @click.option("--base_dir", type=str, show_default=True, default=None, help="DISDRODB base directory")
-@click.option("--raise_error", type=bool, show_default=True, default=True, help="Whether to raise error of finish the check")
+@click.option(
+    "--raise_error", type=bool, show_default=True, default=True, help="Whether to raise error of finish the check"
+)
 def disdrodb_check_metadata_archive(base_dir=None, raise_error=True):
     from disdrodb.metadata.check_metadata import check_archive_metadata_compliance
 

disdrodb/tests/test_l0/test_io.py

@@ -126,7 +126,7 @@ def test_create_directory_structure(tmp_path, mocker):
     assert os.path.exists(l0a_folder_path)
 
 
-def test_check_raw_dir_input(tmp_path):
+def test_check_raw_dir_is_a_directory(tmp_path):
     base_dir = tmp_path / "DISDRODB"
     station_name = "station_1"
     data_source = "data_source"
@@ -139,7 +139,7 @@ def test_check_raw_dir_input(tmp_path):
         campaign_name=campaign_name,
         station_name=station_name,
     )
-    io._check_raw_dir_input(str(base_dir))
+    io._check_raw_dir_is_a_directory(str(base_dir))
 
 
 def test_check_directory_exist():
@@ -358,12 +358,12 @@ def test_get_l0b_fpath():
 ####--------------------------------------------------------------------------.
 
 
-def test_check_glob_pattern():
+def test__check_glob_pattern():
     with pytest.raises(TypeError, match="Expect pattern as a string."):
-        io.check_glob_pattern(1)
+        io._check_glob_pattern(1)
 
     with pytest.raises(ValueError, match="glob_pattern should not start with /"):
-        io.check_glob_pattern("/1")
+        io._check_glob_pattern("/1")
 
 
 def test_get_raw_file_list():

disdrodb/tests/test_l0/test_l0b_concat.py

@@ -23,6 +23,7 @@
 
 import numpy as np
 import pandas as pd
+import pytest
 import xarray as xr
 
 from disdrodb.l0.l0_processing import run_l0b_concat
@@ -70,10 +71,6 @@ def create_dummy_l0b_file(filepath: str, time):
 
 
 def test_xr_concat_datasets(tmp_path):
-    # from pathlib import Path
-    # tmp_path = Path("/tmp/test8")
-    # tmp_path.mkdir()
-
     # Write L0B files
     filepath_1 = os.path.join(tmp_path, "test_1.nc")
     filepath_2 = os.path.join(tmp_path, "test_2.nc")
@@ -224,6 +221,10 @@ def mock_write_l0b(ds: xr.Dataset, fpath: str, force=False) -> None:
 
 
 def test_run_disdrodb_l0b_concat(tmp_path):
+    # from pathlib import Path
+    # tmp_path = Path("/tmp/test10")
+    # tmp_path.mkdir()
+
     # Define stations info
     base_dir = os.path.join(tmp_path, "DISDRODB")
     data_source = "data_source"
@@ -270,3 +271,14 @@ def test_run_disdrodb_l0b_concat(tmp_path):
     # Assert the presence of 2 concatenated netcdf files (one for each station)
     list_files = glob.glob(os.path.join(base_dir, "Processed", data_source, campaign_name, "L0B", "*.nc"))
     assert len(list_files) == 2
+
+    # Check that if L0B files are removed, raise error if no stations available
+    with pytest.raises(ValueError):
+        run_disdrodb_l0b_concat(
+            base_dir=base_dir,
+            data_sources=data_source,
+            campaign_names=campaign_name,
+            station_names=[station_name1, station_name2],
+            remove_l0b=True,
+            verbose=False,
+        )