Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader cleaning #131

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Reader cleaning #131

merged 1 commit into from
Dec 6, 2022

Conversation

ghiggi
Copy link
Collaborator

@ghiggi ghiggi commented Dec 5, 2022

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the branch named as follows:
    • Add a reader: reader-<institute>-<campaign>
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>

Summary

This PR cleans up most of the readers developed by @KimCandolfi.
It also introduces some further L0A processing checks:

  • Coercion of possible numeric columns corrupted values to np.nan
  • Strip trailing/leading space from string columns
  • Ensure the data frame without duplicate timesteps (keeps the first)

In conclusion, this PR will help @regislon to set up the tests for most readers.
#130 lists some problems and TODO list related to remaining readers and the next improvements in L0A processing to be done.

@ghiggi ghiggi requested a review from regislon December 5, 2022 17:51
@regislon regislon merged commit 5bf02a4 into ltelab:main Dec 6, 2022
@ghiggi ghiggi deleted the refactor-readers branch February 13, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants