Specifying kms is required when converting an account to a key.

Fix: Pass default kms when creating a key
ltonetwork · Jul 21, 2023 · 37c1535 · 37c1535
1 parent f6f8c4b
commit 37c1535
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/convert.ts b/src/convert.ts
@@ -26,7 +26,7 @@ export function ofIdentifier(identifier: IIdentifier): IAccountIn {
   return ofKey(managementKey);
 }
 
-export function accountAsKey(account: Account, { kms, type }: { kms?: string; type?: 'sign' | 'encrypt' }): IKey {
+export function accountAsKey(account: Account, { kms, type }: { kms: string; type?: 'sign' | 'encrypt' }): IKey {
   type ??= 'sign';
   let keyType: TKeyType;
   let keyPair: IKeyPairBytes;
@@ -42,7 +42,7 @@ export function accountAsKey(account: Account, { kms, type }: { kms?: string; ty
 
   return {
     kid: `${account.did}#${type}`,
-    kms: kms || 'kms',
+    kms: kms,
     privateKeyHex: keyPair.privateKey?.hex,
     publicKeyHex: keyPair.publicKey.hex,
     type: keyType,

diff --git a/src/lto-did-provider.ts b/src/lto-did-provider.ts
@@ -108,7 +108,7 @@ export class LtoDIDProvider extends AbstractIdentifierProvider {
   ): Promise<IKey> {
     if (!account.signKey.privateKey) throw new Error('Account does not have a private key');
 
-    const key = accountAsKey(account, { kms, type: 'sign' }) as Required<IKey>;
+    const key = accountAsKey(account, { kms: kms || this.defaultKms }) as Required<IKey>;
     return await context.agent.keyManagerImport(key);
   }
 
@@ -119,7 +119,7 @@ export class LtoDIDProvider extends AbstractIdentifierProvider {
   ): Promise<IKey> {
     if (!account.encryptKey.privateKey) throw new Error('Account does not have a private encryption key');
 
-    const key = accountAsKey(account, { kms, type: 'encrypt' }) as Required<IKey>;
+    const key = accountAsKey(account, { kms: kms || this.defaultKms, type: 'encrypt' }) as Required<IKey>;
     return await context.agent.keyManagerImport(key);
   }