Install bash completion into share/bash-completion/completions/pizauth.
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Sat, Jan 20, 2024 at 11:53:23AM -0800, Laurence Tratt wrote:
Having looked at a couple of platforms (including OpenBSD, where `pkg-config --variable completionsdir bash-completion` doesn't return a value), it seems that `share/bash-completion/completions/pizauth` is the best overall choice.
@hseg Does this make sense?
LGTM, mod the typo `bash-completions` -> `bash-completion`
|
|
Thanks! |
ltratt
force-pushed
the
move_bash_completion_install
branch
from
e91423f
to
1893493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having looked at a couple of platforms (including OpenBSD, where
pkg-config --variable completionsdir bash-completiondoesn't return a value), it seems thatshare/bash-completion/completions/pizauthis the best overall choice.@hseg Does this make sense?