Prepare a 1.0.4 release.

[ltratt]

@hseg This release bundles up the new installation + completion + systemd stuff, so a final check from you would be much appreciated!

[hseg]

On Mon, Jan 22, 2024 at 10:04:49AM -0800, Laurence Tratt wrote: @hseg This release bundles up the new installation + completion + systemd stuff, so a final check from you would be much appreciated!

Minor remarks, none of them fatal -- feel free to disregard or push off to a future papercut-squashing pass. Going through the history, I see you mildly lament the loss of BSD make in c18c702. Considering the only GNU-only feature used is `ifeq`, if you want compatibility with BSD make you could always replace it with a `case` statement. Also, I notice you didn't update the `distrib` target to include `README.Linux.md` (BTW, isn't the standard name for this target `dist`?). It is also missing the prerequisites (ie the list of files it depends on) -- for that matter, so is `target/release/pizauth` (which has the implication that `make` will try rebuilding all files. OTOH, this may be innocuous here, since `cargo` might be handling it). (Incidentally, the main sources I've been using to figure out what Makefiles should look like are [1][2][3][4][5]). Checking `build.rs`, I see the `rerun_except` list is out-of-date (missing `examples`, `lib/systemd/user/pizauth.service`, `README.Linux.md`, `COPYRIGHT`, and `Makefile` by my count) -- perhaps have it pull from the same source as the `make dist` target? Finally, now I look at it, perhaps you'd like to place `lib/systemd/user/pizauth.service` under `examples` or directly into the root directory (only for the repo, not the in the installation, of course) -- there's no need to organize the repo by where things are installed to, after all. [1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html [2]: https://man.openbsd.org/make.1 [3]: https://man.openbsd.org/bsd.port.mk.5 [4]: https://www.gnu.org/prep/standards/html_node/Makefile-Conventions.html [5]: https://sarielhp.org/teach/1998/soft99a/unix_help/make/make_16.html

[ltratt]

@hseg I admit ignorance over case --- how does that work in both BSD and GNU make?

[hseg]

On Mon, Jan 22, 2024 at 12:58:51PM -0800, Laurence Tratt wrote: @hseg I admit ignorance over `case` --- how does that work in both BSD and GNU make?

Ah, misread https://stackoverflow.com/a/52944742, my bad. A different portable approach (I assume you've tested this on BSD make already) is to use a variation on the `MANDIR` hack again: ```Makefile PLATFORM=$$(uname -s) HASSYSTEMD=$$(case $$(uname) in (Linux) echo SYSTEMD;; (*) echo NOSYSTEMD;;esac) install.SYSTEMD: ... install lib/systemd/user/pizauth.service ... install.NOSYSTEMD: install: target/release/pizauth install.${PLATFORM} ... ``` NB: I haven't tested this actually works, please check