Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023.9.1-117: Add a pseudo icon - blank #118

Merged
merged 3 commits into from
Oct 29, 2023
Merged

2023.9.1-117: Add a pseudo icon - blank #118

merged 3 commits into from
Oct 29, 2023

Conversation

andrewjswan
Copy link

@andrewjswan andrewjswan force-pushed the 2023.9.1-117-Add_a_pseudo-icon_-_blank branch from 3776700 to 421a8ba Compare October 23, 2023 16:58
@andrewjswan
Copy link
Author

I reworked the logic a bit, built a generic branch for the test, from 2023.9.1 + PR 118, 119 ... It works without degradation.

@andrewjswan
Copy link
Author

4 days, no problems, everything is stable in all modes.

@lubeda
Copy link
Owner

lubeda commented Oct 28, 2023

Why -1 for the blank icon wouldn't ID 0 more natural?

@andrewjswan
Copy link
Author

Why -1 for the blank icon wouldn't ID 0 more natural?

-1 was the original version, it failed, the working and final version is MAXICONS + 1

@andrewjswan
Copy link
Author

@lubeda look - https://github.com/lubeda/EspHoMaTriXv2/pull/118/files#diff-345f4882a9621cc8a04520b628475a419357f3b98b092260e4749d646698ab16R24

@lubeda lubeda merged commit 2f00fb1 into lubeda:2023.9.1 Oct 29, 2023
3 of 5 checks passed
@andrewjswan andrewjswan deleted the 2023.9.1-117-Add_a_pseudo-icon_-_blank branch October 29, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubeda lubeda lubeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewjswan @lubeda