Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.9.1-123: Scroll icon along with long text #127

Merged

Conversation

andrewjswan
Copy link

@chertvl
Copy link

chertvl commented Oct 29, 2023

#123

I tried it and it's exactly what I wanted!
It works very well
Thank you!

@lubeda
Copy link
Owner

lubeda commented Oct 30, 2023

i`ll take look at the PRs in the next days

@chertvl
Copy link

chertvl commented Oct 30, 2023

Found a little bug.
If I send the text that is too long to fit in screen with icon, but at the same time too short for scrolling (<32px),
then icon will partially extend beyond the screen, but the screen will not scroll.
Only half of the icon will be visible and there will be no scrolling.

image

@andrewjswan
Copy link
Author

I'll take a look tomorrow.

@andrewjswan andrewjswan marked this pull request as draft October 30, 2023 21:54
@andrewjswan
Copy link
Author

Made the changes, will test today, if it works I'll bring it back from draft state.

@andrewjswan andrewjswan marked this pull request as ready for review October 31, 2023 19:41
@andrewjswan
Copy link
Author

Looks like it's fixed.

@chertvl
Copy link

chertvl commented Oct 31, 2023

Looks like it's fixed.

Just tested this one, and its looks like fixed! Thank you
LGTM ;)

@lubeda lubeda merged commit 34f9bf2 into lubeda:2023.9.1 Nov 1, 2023
5 checks passed
@andrewjswan andrewjswan deleted the 2023.9.1-Scroll_icon_along_with_long_text branch November 1, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants