Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageLoaderTask.TryLoadFromMemoryCacheAsync(string,bool,bool,bool) is throwing NullReferenceException when the cache contains null #1523

Open
3 of 7 tasks
thisisthekap opened this issue Jan 25, 2021 · 0 comments · May be fixed by #1524
Open
3 of 7 tasks

ImageLoaderTask.TryLoadFromMemoryCacheAsync(string,bool,bool,bool) is throwing NullReferenceException when the cache contains null #1523

thisisthekap opened this issue Jan 25, 2021 · 0 comments · May be fixed by #1524

Comments

@thisisthekap
Copy link

🐛 Bug Report

If for whatever reason the dictionary MemoryCache contains null as value for an existing dictionary entry, the method will result in throwing a NullReferenceException.

Expected behavior

As the Method is named "TryLoadFromMemoryCacheAsync", the method should just return false instead

Reproduction steps

Reported by our production error reporting, unfortunately no reproduction steps available

Configuration

Version: 2.4.11.982

Platform:

  • 📱 iOS
  • 🤖 Android
  • 🏁 WPF
  • 🌎 UWP
  • 🍎 MacOS
  • 📺 tvOS
  • 🐒 Xamarin.Forms
@thisisthekap thisisthekap linked a pull request Jan 25, 2021 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

made ImageLoaderTask.TryLoadFromMemoryCacheAsync null safe thisisthekap/FFImageLoading
1 participant
@thisisthekap