-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made ImageLoaderTask.TryLoadFromMemoryCacheAsync null safe #1524
base: master
Are you sure you want to change the base?
Conversation
@daniel-luberda The failing AppVeyor build seems to be unrelated to my change. |
@daniel-luberda Is my change breaking the CI? |
@daniel-luberda @molinch The build seems to be broken since https://ci.appveyor.com/project/daniel-luberda/ffimageloading/builds/35814199 |
@daniel-luberda @molinch Can you provide any schedule when this PR is going to be processed? |
Same problem |
@artemtishchenkobinwell I provided a fix in this PR, but unfortunately, I do not know if or when this PR will get reviewed. |
Same problem |
1 similar comment
Same problem |
@artemtishchenkobinwell @SelyutinSergey @maukur If you feel fearless, you might build your custom nuget with my fix included. Of course without any warranty. |
@daniel-luberda @molinch Is this PR going to get reviewed, or should it be closed? |
I'll keep that PR open for fellow developers who are stumbling upon the related issue. As this repository seems to be abandoned, there is no further action taken from my side. |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Fixes #1523
NullReferenceException thrown, when ImageLoaderTask.MemoryCache has entries with
null
values.🆕 What is the new behavior (if this is a feature change)?
No NRE anymore, just reporting it as cache miss.
💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
None, as #1523 was reported by our production error reporting, and unfortunately no reproduction steps are available.
📝 Links to relevant issues/docs
None
🤔 Checklist before submitting