Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop docker #21

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

janmalec
Copy link

Hello! I have created a Dockerfile and attached a short text file with build instructions. Best, Jan

@luca-fiorito-11 luca-fiorito-11 changed the base branch from master to develop April 29, 2019 09:30
Copy link
Owner

@luca-fiorito-11 luca-fiorito-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the base branch from master to develop.
I believe pull requests should always be merged into develop.
I'll add a CONTRIBUTING file to explain this point.

RUN apt install -y gfortran python3 python3-setuptools\
python3-numpy python3-dev unzip ca-certificates

COPY sandy-develop.zip /
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using COPY and a zip file, install git and run a clone command. 😉

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, I will change the Dockerfile and push the update!

@janmalec
Copy link
Author

Hello! I have finally updated the Dockerfile as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants