This repository has been archived by the owner on Feb 27, 2020. It is now read-only.
Adds historical price api #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* previously there was not a way to get the historical price of
a coin at a point in time. This allows you to get the current price
and also get the price at any historical time.
|
Some of the tests are not passing because of some bad type conversions. I am new to go and don't really know what needs to be done. This code was just copied from price.go and I modified all the names to include Was hoping you could let me know what I need to change here here to make the tests pass. The example seems to work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a coin at a point in time. This allows you to get the current price
and also get the price at any historical time given a unix timestamp.