Upgrade SolidStart to v1 #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERmilburn02
suggested changes
Jun 17, 2024
There was a problem hiding this comment.
Why was Typescript added as a dependency to the root project?
| "@lucia-auth/adapter-sqlite": "^3.0.1", | ||
| "@solidjs/router": "^0.13.3", | ||
| "@solidjs/start": "^1.0.0", | ||
| "@types/better-sqlite3": "^7.6.10", |
There was a problem hiding this comment.
Why were types moved to regular dependencies?
| "@lucia-auth/adapter-sqlite": "^3.0.1", | ||
| "@solidjs/router": "^0.13.3", | ||
| "@solidjs/start": "^1.0.0", | ||
| "@types/better-sqlite3": "^7.6.10", |
There was a problem hiding this comment.
Again, why are types in regular dependencies? They're not required at runtime, only during development.
ERmilburn02
reviewed
Jun 17, 2024
| return sendRedirect(event, "/"); | ||
| const cookie = lucia.createSessionCookie(session.id); | ||
|
|
||
| setCookie(cookie.name, cookie.value, cookie.attributes); |
There was a problem hiding this comment.
You should be returning here, otherwise you throw an error because you try to add the user to the database again
ERmilburn02
reviewed
Jun 17, 2024
| const cookie = lucia.createSessionCookie(session.id); | ||
|
|
||
| setCookie(cookie.name, cookie.value, cookie.attributes); | ||
| return Response.redirect("/"); |
There was a problem hiding this comment.
This is throwing a type error because it can't parse the URL. Instead you should probably use redirect from @solidjs/router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.