Development #118
Open
Development #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re introduce some cflags in meson script and other fixes
Cosmetic optimizations and fixes.
It is still not functional though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed broken state saving for the stereo mode: strcmp returns zero if matches, strstr returns pointer; replaced everything with strcmp as less ambiguous. Spent several hours trying to identify why soft-bypass works for the mono version and ignored in stereo, it seems that it is because input=output for some reason. Finally thrown a towel and added a crude fix (tested in Ardour 7.5). At least now the plugin is fully-functional. Not sure about what "units:conversion" line does but added it to nrepellent.ttl because it was in all the other files. Optimized some redundant code (for example removed the connect_port_stereo function), probably it all was there as the placeholder for the further development, I dunno.
In theory a new release can be made.