Various bug fixes, refactoring, and additional testing. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nFilter class final.
… intermittent classpath order issue with test-framework/lucene-core
… method. Testing demarcating operations sucks.
… the modified query
…optional, local params
…nd no current implementation for biggest phrase match.
Filter rewrite
Regexes for units of measurement
Unit tests for regular expression parsing
…ments can be included, thus allowing you to match a phrase like 'pay my bill' or 'pay bill' using the syntax 'pay TOKEN bill'
…l, and also to allow the QParserPlugin to work without making Token a 'magic' word, since the QParserPlugin deals with everything in lowercase. Also, updating tests.'
…ta that was crawled by Nutch.
… the 'real' words. Also, refactored the matching algorithm to use recursion for easier reading.
…iness), then it will match incorrectly.
…word boundary to the regex in the parser plugin
Basic Fuzzy Matching Pull Request
…ries and logical operators to fix problems with all caps queries containing same.
Updates to dependencies and code for Solr 5.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working with the filter I found a number of bugs including inability to replace whitespace with nothing and a failure if a partial phrase match was unresolved at the end of a document (document didn't index). I've also extended the testing and refactored a number of things including simplifying the token filter and extracting parameters into their own class.