Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a minor misinformation on how to use --config and --config_str. #363

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

mhabedank
Copy link
Contributor

The docs for the CLI commands have some examples on how to use a config string. The CLI argument --config was falsely used instead of --config_str.

Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@alexsherstinsky
Copy link
Collaborator

@mhabedank The pre-commit hook may have something to do with the line lengths -- please paste the error code here, and we can try figure it out together (unless you already found out what was causing it). Thanks a lot for your contribution!

@mhabedank
Copy link
Contributor Author

image

Rule E201 was broken. I manually edited the line, I wonder why the pre-commit hook didn't failed locally on my machine

@arnavgarg1 arnavgarg1 merged commit c423ee4 into ludwig-ai:master Jun 25, 2024
2 checks passed
@mhabedank mhabedank deleted the fix-cli-example branch June 25, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants