Still allow providing a callback #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repl-mike-roest
changed the title
|
Great contribution, thank you very much. |
|
@repl-mike-roest your changes have gone out now as 2.8.0 |
|
Awesome @luispabon thanks so much! |
|
I just realized my example in the readme is wrong. I'll have a new PR in a couple of minutes to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@luispabon just adding the ability here to still provide a callback while allowing for delays.
Our use case here is we need to inspect the response body to make the determination about whether to retry or not we can't just rely on the response code. With vanilla superagent we can do this but then it just fires all the retries as fast as possible. With this change we will be able to use the delaying functionality of superagent-retry-delay while not losing the ability to deep dive into response/error to make the retry decision.