Mirror superagent behaviour in call back for creating errors

[repl-mike-roest]

In our use of this delay module we noticed a difference in our end callback behaviour when just including the retry-delay. This is porting https://github.com/ladjs/superagent/blob/master/src/node/index.js#L893-L908 this section of the core superagent callback into the retry-delay callback to create errors on a non-ok response. to mirror the core superagent behaviour

[repl-mike-roest]

@luispabon any chance to get this merged?

Thanks

[luispabon]

Thank you Mike. This significantly changes the error handling interface, I'd need to issue a new major version to ensure semver is respected. Could you please let me know which version of superagent you at?

[repl-mike-roest]

Thank you Mike. This significantly changes the error handling interface, I'd need to issue a new major version to ensure semver is respected. Could you please let me know which version of superagent you at?

We were on 3.6.0 and I also tried it on 8.1.2 they both appear to have the same error synthesizing behaviour on nonOk responses.

[repl-mike-roest]

@luispabon yep no problem added tests for the new error synthesizing cases. And yah I think a new major version makes sense. Although it's bringing the behaviour inline with the core superagent it is a major change from this plugin's point of view.

[repl-mike-roest]

@luispabon sorry to be a pain, just wondering if you have a rough idea of when you would have time to get this in?

Thanks

[luispabon]

https://github.com/luispabon/superagent-retry-delay/actions/runs/6733950566 <-- published 3.0.0

[repl-mike-roest]

https://github.com/luispabon/superagent-retry-delay/actions/runs/6733950566 <-- published 3.0.0

You rock thanks so much!

[luispabon]

No, thanks for your contribution 👍🏽

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (9b3dd9e) to head (01926c9).
Report is 18 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   84.90%   91.17%   +6.27%     
==========================================
  Files           1        1              
  Lines          53       68      +15     
==========================================
+ Hits           45       62      +17     
+ Misses          8        6       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.