Cloud Spanner Lock Provider #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having issues with Will see what I can do. |
|
Hi, thanks a lot. I will look at the PR soon |
lukas-krecan
reviewed
Nov 6, 2023
| <archive> | ||
| <manifestEntries> | ||
| <Automatic-Module-Name> | ||
| net.javacrumbs.shedlock.provider.mongo |
|
Hi, I have taken the liberty to do some small refactorings here. If you are OK with the changes, I will merge it and release it. Thanks again. |
|
Looks great to me! |
|
Release as 5.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a Google Cloud Spanner lock provider for Shedlock.
This implementation respects Spanner's transactionality by making use of read and write mutations within a transactional context.
The implementation is based on the
StorageBasedLockProviderand accessor.Tests extend
AbstractStorageBasedLockProviderIntegrationTestand make use of the Spanner emulator in a test container to test integration.I've also included an optional
Configurationclass when creating the lock provider which can be used for a custom host name, table and column names.Finally, I was unsure if I was supposed to update the readme and parent pom with the new module. I did so anyway, but I'm of course open to change that and anything else as per your requirements.