Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error with type casted object with namespace #1713

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

chappelo
Copy link
Contributor

@chappelo chappelo commented Nov 2, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

closes #1706

as discussed in the issue, prettyTroubleCause does error. adding the extra falsy check does fix.

@chappelo chappelo changed the title falsy check fix: error with type casted object with namespace Nov 2, 2024
@WoH
Copy link
Collaborator

WoH commented Nov 11, 2024

LGTM, I haven't checked the dependency between getText and parent, but it makes sense.

@WoH WoH merged commit 45de0fa into lukeautry:master Nov 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsoa crashes due to missing check in prettyTroubleCause
2 participants