Ensure null/undefined id is not rendered

lukebayes · Oct 14, 2024 · bf394e9 · bf394e9
1 parent ea10101
commit bf394e9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nomplate",
-  "version": "1.3.27",
+  "version": "1.3.28",
   "description": "Nomplate: Node template engine",
   "main": "index.js",
   "engines": {

diff --git a/src/operations.js b/src/operations.js
@@ -13,7 +13,9 @@ function top(stack) {
 
 function setId(value) {
   return function _setId(domElement, stack, document) {
-    domElement.id = value;
+    if (value !== null && value !== undefined) {
+      domElement.id = value;
+    }
     return domElement;
   };
 }

diff --git a/test/render_element_test.js b/test/render_element_test.js
@@ -30,6 +30,11 @@ describe('renderElement', () => {
       assert.equal(domElement.outerHTML, '<div id="abcd"></div>');
     });
 
+    it('creates element with null id', () => {
+      const domElement = renderElement(dom.div({id: null}), doc);
+      assert.equal(domElement.outerHTML, '<div></div>');
+    });
+
     it('assigns textContent', () => {
       const domElement = renderElement(dom.div('one'), doc);
       assert.equal(domElement.outerHTML, '<div>one</div>');