Feature assignable container #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worked in my test case but I'd be happy if people could test some more and give feedback |
|
This is not working for my test case: www.ashwebdev.com/buchanan Trying to recreate http://www.hugeinc.com/ where there is additional content at the bottom which has normal scroll |
|
This update changes the syntax for all of Scrollify's public methods. Introducing the |
|
+1 for this options |
|
It does not align the sectons in the container correct when body already scrolled down. |
|
maybe this PR is not working as expected, but this plugin really need this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignable container feature via$(".container").scrollify(), still backwards compatible to use $ .scrollify()