Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll in some Android devices #223

Closed
wants to merge 2 commits into from

Conversation

davidbayo10
Copy link

Scrollify was not working correctly in some Android Devices. So, I bring you the solution.

David Bayo added 2 commits April 2, 2017 20:08
Scrollify wasn't working in some Android Devices
@kitsunde
Copy link

Ah I didn't spot this, so I did the same thing although mine detects passive support, keeps existing options and makes sure the removeEventListener still works.

#245

@davidbayo10
Copy link
Author

But that PR didn't build minified version. You should accept someone else, and close other.

@kitsunde
Copy link

kitsunde commented Aug 30, 2017

Building a minified version in pull a requests isn't very useful since virtually every pull request would cause a merge conflict.

Like this one. :P

@davidbayo10
Copy link
Author

then Will you close this PR?

@kitsunde
Copy link

It's not my project, I'm just some dude that sent a different PR.

@davidbayo10
Copy link
Author

ok

@lukehaas
Copy link
Owner

Closing as it looks like these changes have made their way in via a different PR.

@lukehaas lukehaas closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants