Default hash #46
Open
Default hash #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! |
|
Thanks for suggesting this. There isn't really a strong need to have the hash set on the first page load so will be making this the default behaviour in the next update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's awesome plugin, I used it on many sites. But most of the client not wish to have the hash tag on first page load. for example
my-site.com/#homethis is the first page load url, but clients not willing to have#homehash tag on first page load. So I added the option in the plugin called'defaultHash':true. So users can easily decide hash tag should come on the first page load or not.I think it's useful to have this option. may be we need to change the name or something. Let me know what you think.