refactor: detach Title component from Header component

lumirlumir · Sep 16, 2024 · 4ce4f06 · 4ce4f06
1 parent bb31a6e
commit 4ce4f06
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 9 deletions.
diff --git a/src/app/layout.jsx b/src/app/layout.jsx
@@ -9,6 +9,8 @@ import Main from '@/components/layouts/Main';
 import Categories from '@/components/aside/Categories';
 import Home from '@/components/aside/Home';
 
+import Title from '@/components/header/Title';
+
 // TODO: import '@/styles/global.scss';
 
 // TODO: export const metadata = {
@@ -20,7 +22,9 @@ export default function RootLayout({ children }) {
   return (
     <html lang="ko">
       <Body>
-        <Header />
+        <Header>
+          <Title />
+        </Header>
         <Aside>
           <Home />
           <Categories />

diff --git a/src/components/header/Title/Title.jsx b/src/components/header/Title/Title.jsx
@@ -0,0 +1,7 @@
+import Link from 'next/link';
+
+import { USER } from '@/constants/github';
+
+export default function Title() {
+  return <Link href={USER.htmlUrl}>{USER.name}</Link>;
+}
diff --git a/src/components/header/Title/index.js b/src/components/header/Title/index.js
@@ -0,0 +1,3 @@
+import Title from './Title';
+
+export default Title;
diff --git a/src/components/layouts/Header/Header.jsx b/src/components/layouts/Header/Header.jsx
@@ -1,11 +1,5 @@
-import { USER } from '@/constants/github';
-
 import styles from './Header.module.scss';
 
-export default function Header() {
-  return (
-    <header className={styles.header}>
-      <a href={USER.htmlUrl}>{USER.name}</a>
-    </header>
-  );
+export default function Header({ children }) {
+  return <header className={styles.header}>{children}</header>;
 }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import Title from './Title';

		export default Title;