Add various optional functionality #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✓ Add toggle to include headings (defaults to off) in rollover- this is useful for my personal workflow. Right now items under heads are carried over, but the headings themselves are not.
✓ Add toggle to include bulleted items in rollover. Current behavior is that bulleted items (and sub items) of a TODO are carried over, but not top-level bullets.
✓ Add toggle to not roll over completed sub-todos
✓ Add toggle to filter child items of todos. Right now all are included. Respects above settings to check for headers and bullets.
✓ Added some tests around these scenarios
✓ Fixed existing broken tests. Two tests were expecting array of empty string when it should have been empty array, and another test wasn't expecting a completed child TODO, when it should actually be expecting it AFAICT. These tests are broken in latest master, prior to my changes.
Please let me know if this is something you'd consider merging, or if there's additional testing / other strategies for approaching these additions.