Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests) fix tests failing on Lua 5.4 #323

Merged
merged 3 commits into from
Jul 28, 2020
Merged

fix(tests) fix tests failing on Lua 5.4 #323

merged 3 commits into from
Jul 28, 2020

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Jul 28, 2020 •
edited
Loading

closes #321
closes #320

@Tieske Tieske force-pushed the lua54 branch 3 times, most recently from 29d034f to 931518a Compare July 28, 2020 08:03
@Tieske
Copy link
Member Author

Tieske commented Jul 28, 2020

luacheck has its rockspec hardcoded to 5.1 - 5.3 versions of Lua, that tool is currently unmaintained, and does seem to have some issues with Lua 5.4 (did some manual tests)

luacov is used in CI, and is also pinned to 5.1 - 5.3 versions, but an older version (0.11.x and before) is not pinned, so effectively LuaRocks will resolve the LuaCov dependency for Lua 5.4 to that older version, and then the test run fails because of some long fixed bug in that older version. Running with the SCM rockspec works fine.

@Tieske
Copy link
Member Author

Tieske commented Jul 28, 2020

For now I disabled LuaCov and LuaCheck on the Lua 5.4 CI run.

@Tieske Tieske merged commit d17c78b into master Jul 28, 2020
@Tieske Tieske deleted the lua54 branch July 28, 2020 12:49
@mcepl mcepl mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail under Lua 5.4
1 participant
@Tieske