Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add float type and test cases for float and double types. #182

Open
usefulhyun opened this issue Nov 12, 2017 · 2 comments
Open

Add float type and test cases for float and double types. #182

usefulhyun opened this issue Nov 12, 2017 · 2 comments
Assignees
@usefulhyun

Comments

@usefulhyun
Copy link
Contributor

Implementing float type is required
And proper test cases for float and double type is needed.
@nadongguri
Copy link
Contributor

Those type have been already processed by @gogag2, in this issue.
As of now, float is not implemented actually but do we need additional patches for the double implementation?
Also, that table is required to update. :)

@usefulhyun
Copy link
Contributor Author

I will create a test case that compares precision between double and float.
and there is only one test case for doubleand which is a weak case.

@usefulhyun usefulhyun mentioned this issue Nov 15, 2017
Merged
romandev pushed a commit that referenced this issue Nov 25, 2017
@usefulhyun @romandev
Add float type and test cases for float and double type. (#187)
d47d88f 
This patch includes the implementation of `float` type
and extensive test cases for `float` and `double` type.
- implementation of `float` type and its test interface.
- test cases for `float` and `double` type.
   
ISSUE=#182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usefulhyun usefulhyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@usefulhyun @nadongguri