Add float type and test cases for float and double type. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulhyun
requested review from
hwanseung,
romandev and
yjaeseok
as code owners
romandev
reviewed
Nov 18, 2017
test/interface_basic_types.test.ts
Outdated
|
|
||
| expect(test_interface.floatMethod(0.0)).toBe(0.0); | ||
|
|
||
| var base = 1 / 2 |
There was a problem hiding this comment.
Please use const instead of var.
Also, you missed semi-colon ;.
test/interface_basic_types.test.ts
Outdated
| // the same, so we can not test the value out of the range. | ||
|
|
||
| // NaN == NaN returns false, thus we must use isNaN function | ||
| expect(isNaN(test_interface.doubleMethod(NaN))).toBe(true); |
There was a problem hiding this comment.
IMHO, float and double SHOULD NOT take these special values such as NaN, Infinity and -Infinity.
They are only allowed in unrestricted float and unrestricted double.
Please see: https://heycam.github.io/webidl/#idl-unrestricted-float
romandev
reviewed
Nov 24, 2017
There was a problem hiding this comment.
@usefulhyun Ah, I didn't know that you already updated this patch.
Sorry for delayed review.
test/interface_basic_types.test.ts
Outdated
| // unrestricted. | ||
| const base = 1 / 2; | ||
| const precision = 52; | ||
| for (var test_case = 0; test_case < 100; test_case++) { |
There was a problem hiding this comment.
Please use let instead of var. The var is function scope and let is block scope.
So, we prefer to use let to avoid unexpected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes the implementation of
floattypeand extensive test cases for
floatanddoubletype.floattype and its test interface.floatanddoubletype.ISSUE=#182