Write a test for enum type using jest. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romandev
reviewed
Oct 8, 2017
test/test_interface.idl
Outdated
| @@ -32,4 +32,13 @@ interface TestInterface { | |||
| short shortMethod(short number); | |||
| double doubleMethod(double number); | |||
| string stringMethod(string string); | |||
|
|
|||
| // enum | |||
| void EnumMethod(TestEnum enumValue); | |||
There was a problem hiding this comment.
nit: Should be enumMethod(...) in IDL.
Also, I think better name is voidMethodTestEnumArg(...)
test/test_interface.cc
Outdated
| @@ -64,3 +64,7 @@ double TestInterface::DoubleMethod(double number) { | |||
| const std::string TestInterface::StringMethod(const std::string& string) { | |||
| return string; | |||
| } | |||
|
|
|||
| void TestInterface::EnumMethod(const std::string& string) { | |||
| last_call_info_ = "EnumMethod(" + string + ")"; | |||
There was a problem hiding this comment.
The string should be IDL definition like other methods.
"void voidMethodTestEnumArg(TestEnum)";
romandev
approved these changes
Oct 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a test for enum type using jest.
ISSUE=#99,#100