Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for enum features #190

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Add tests for enum features #190

merged 1 commit into from
Nov 18, 2017

Conversation

hwanseung
Copy link
Contributor

@hwanseung hwanseung commented Nov 18, 2017 •
edited by romandev
Loading

Add tests for enum features

  • Add test for function which return enum values
  • Add test passing unexpected value instead of enum

ISSUE=#80

@hwanseung
Add tests for enum features
9398058 
 - add test for function which return enum values.
 - add test passing unexpected value instead of enum.

ISSUE=lunchclass#80
romandev
romandev approved these changes Nov 18, 2017
View reviewed changes
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romandev romandev merged commit e5123a5 into lunchclass:master Nov 18, 2017
@hwanseung hwanseung deleted the return_enum branch December 13, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romandev romandev romandev approved these changes

@yjaeseok yjaeseok Awaiting requested review from yjaeseok yjaeseok is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwanseung @romandev