Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform-specific commands #195

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Remove platform-specific commands #195

merged 1 commit into from
Nov 22, 2017

Conversation

romandev
Copy link
Member

No longer need the platform-specific commands.

ISSUE=#193

@yjaeseok
Copy link
Contributor

gyp: Dependency 'binding.gyp:require(node-addon-api).gyp#target' not found while trying to load target binding.gyp:bacardi#target

gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1

@yjaeseok yjaeseok closed this Nov 20, 2017
@yjaeseok yjaeseok reopened this Nov 20, 2017
@romandev romandev force-pushed the platform branch 6 times, most recently from 577de9a to 47d3e28 Compare November 22, 2017 17:29
No longer need the platform-specific commands.

ISSUE=#193
@yjaeseok
Copy link
Contributor

lgtm

@romandev romandev merged commit 3c2cfbd into master Nov 22, 2017
@romandev romandev deleted the platform branch November 22, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants