add missing env informations to block #401

[nadar]

closes #401

[hbugdoll]

For env options 'index', 'itemsCount', 'isFirst', 'isLast', 'isPrevEqual', 'isNextEqual' and 'equalIndex' it's fine now.
But for env option 'pageObject'

luya-module-cms/src/models/NavItemPage.php

Line 479 in 1a867a8

$blockObject = $blockItem->block->getObject($blockItem->id, 'admin', $navItemPage);

is still wrong – NavItem instead of NavItemPage is needed as third argument.

[hbugdoll]

I've made new unit tests for the envOptions: ef4efcd.

And they have proven their worth – my 'equalIndex' iteration was wrong (post-increment vs. pre-increment), see 2d3be0d.

Block Test

• Added new BlockTest::testBlockEnvOptions()
• Enhanced therefore TestBlock::admin()
  • Accessing and returning envOptions and unused config value
• Improved BlockTest::testBlockValues() (checking unused config value)

Block Placeholder Iteration Test

• Added new test BlockPlaceholderIterationTest::testEnvOptionsPlaceholderIteration()
  • 3 equal blocks on 1 page via fixtures
  • Checking envOptions in admin context via NavItemPage::getPlaceholder()
  • Checking envOptions in frontend context via NavItemPage::renderPlaceholder()
• Added therefore new testing block TestingEnvOptionsBlock
  • Accessing on envOptions in admin context inside renderAdmin()
  • Accessing on envOptions in frontend context inside renderFrontend() (JSON decoding/encoding is needed because of internal processing & concat)
• Completed access on all block models in BlockPlaceholderIterationTest::testRenderPlaceholderIteration() for sake of completeness

[nadar]

@hbugdoll i will merge this PR.. You can send then a PR with only the unit tests and the according fix. ok? Afterwards we will take a look at the page object in another PR.

[nadar]

@hbugdoll you can now create a fresh merge request using the latest master (don't forget to create a branch on your fork).

[hbugdoll]

@hbugdoll you can now create a fresh merge request using the latest master (don't forget to create a branch on your fork).

Ok, done → #407