Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed website relation for nav container #412

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

hbugdoll
Copy link
Member

What are you changing/introducing

  • Fixed website relation for nav container in NavContainer::getWebsite()
  • Therefore enhanced the corresponding unit test in NavContainerTest::testFindWebsiteContainer()
  • BTW fixed multiple specifications in rules() (added in cc98941)

What is the reason for changing/introducing

  • SQL error when accessing navContainer->website:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'website_id' in 'where clause'
The SQL being executed was: SELECT * FROM `cms_website` WHERE (`cms_website`.`is_deleted`=FALSE) AND (`website_id`=1)

QA

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues

@nadar
Copy link
Member

nadar commented Feb 26, 2024

pefect!

@nadar nadar merged commit 496cebc into luyadev:master Feb 26, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants