Fix #82 Elision: match 1 or more returned types #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner way to fix Issue uber-go#82 However, I am unable to account for what reason did
Match
inpos.go
originally return false in this case. By making this change, there's a risk thatI'm missing out an edge case where
if !got.IsValid() && m.Pos.IsValid() {
should return false but because of the above change would return true & give wrong result.
This passes on all the current testcases and some other tests that I tried but still a risk.
Can test by running