Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mouse forward/back button to change image #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakar
Copy link

@jakar jakar commented Jun 30, 2018

I find myself wanting to use these buttons out of habit, especially when thumbnail view isn't open. With the wheel, sometimes I'll accidentally skip over an image or two.

@jakar
Copy link
Author

jakar commented Jul 1, 2018

Please review this carefully. The mouse event handlers in ImageView don't check the button, so this change, as is, might affect those. One of the following might be necessary:

  • Return true after calling on_action{Next,Previous}_triggered in MainWindow::eventFilter.
  • Test event->button() in ImageView::mousePressEvent and so on.

However, it seems like this depends on the desired behavior of mouse cursor. So maybe neither is necessary.

@tsujan
Copy link
Member

tsujan commented Apr 26, 2019

I'm not sure but this may interfere with the new annotation capability. Someone having a mouse with forward/backward buttons should test it. Can annotations be drawn with those buttons and without this patch? If yes, forward/backward buttons should be excluded from annotations first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants