-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add panel padding property #1940
base: master
Are you sure you want to change the base?
Conversation
FYI: Due to these lines setting the padding on the "outer" QFrame behaves like what is described as "inset" in the QtQuick::Control documentation linked above. Taking this little - important - detail into account and setting the padding on the "inner" QFrame the behavior is exactly as expected and the panel contents start to "shrink"… 🎉 |
@stefonarch Functionality is complete. From what I remember giving negative numbers allows for "floating" panels in LXQt (similar to KDE's panel). It adds a little bit flexibility for customization. Please let me know if and what you need for translations. Initialization I don't know if that is even required and I don't have the time to build and test this. |
Padding works. It's results are similar to "icon size" and other configurations in the final result. panel2.mp4The worldclock plugin goes out of panel instead:
Not really: |
To make this fully work, the font (px) size has to be relative the plugin's (icon)…
This is independent from the padding itself and so I don't see it in this PR (requires touching all plugins). |
references #909
TODO:
Initialize dialog fields.(should be 0)