Show a notification when the battery is present, not absent

[tsimonq2]

In virtual machines especially, it is odd to see a message about the battery not being present. This commit moves that message to only display when there is a battery present.

The code is still slightly rough, but I'd like thoughts on the general idea.

Thanks.

[stefonarch]

It's also about disabling the icon in status notifier, which in fact makes it impossible to use "Pause idleness checks for *" for PC users. Maybe a more general overhaul is needed, showing a different icon (user-idle-panel ? ) if no battery is present. It can still be disabled.

[tsimonq2]

That's agreeable. I pushed another commit with some cleanup, so this could be reviewed as-is.

[tsujan]

I'd like thoughts on the general idea.

The presence of battery is a normal state for most users. It wouldn't make sense to notify users like, "Your system is fine". I wonder who might like to see notifications about normal states on logging in; I, for one, don't.

[stefonarch]

I agree here. Maybe the message header "No battery!" could be removed or changed, it's quite scary.

"LXQt could not find data about any battery - monitoring disabled" is enough.

[tsujan]

it's quite scary.

Haha... It can't cause a panic attack ;) IMO, it's good as it is.

[tsimonq2]

The presence of battery is a normal state for most users

I disagree. Quite a few statistics point to desktop and laptop users being about equal. When you scale it up to, perhaps, a large cloud deployment, everyone who doesn't care if they have a battery will be warned.

Here's the thing: the long-term goal isn't just to say "hey it's working" - it would be to provide some more details such as remaining time, and if idle is inhibited. Details you'd get by hovering and looking through settings, in a concise way. We have support for notifying if the battery is low; I don't think a green status light would be out of the ordinary. Either way, all desktop users are shown a message that doesn't apply or matter to them. I think a green light message is an improvement over a warning. (Believe me, I don't like seeing it on every fresh install when I log in.)

I would also suggest only notifying that the battery is missing if the device is a laptop. Either way, the point about the tray icon disappearing is pretty valid.

(Then again, I can't name another DE that has such a warning, can you?)

[stefonarch]

it's quite scary.

Haha... It can't cause a panic attack ;) IMO, it's good as it is.

No, but if I yell at you: "You're sitting in front of a screen!" you will say "Yes I know, but why are you telling this to me?"

It's about the first impression LXQt makes, and there is room for improvement IMO.