Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSS Cleanups + FancyMenu for Clearlooks #118

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AzumaHazuki
Copy link
Contributor

Cleaned up the code as requested (several months ago...sorry, I genuinely did not see it!) by @stefonarch - should be ready to merge for 2.0

@stefonarch
Copy link
Member

I'm afraid we can't review this in those few remaining days now.

@AzumaHazuki
Copy link
Contributor Author

2.1 release then? I didn't realize 2.0 was coming out this soon...

@AzumaHazuki
Copy link
Contributor Author

Is there a way to just accept the dev team's lxqt-config.qss changes? My version of that file didn't do anything so there's no harm in overriding it.

@stefonarch
Copy link
Member

The file had just different contents between your version and master.
Will take a look again later, lots of files.

Copy link
Member

@stefonarch stefonarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Spacer has no visible line|dots anymore it looks it was always buggy like that
  • wallpaper.cfg has to be added again

themes/Clearlooks/lxqt-panel.qss Outdated Show resolved Hide resolved
themes/Clearlooks/lxqt-panel.qss Outdated Show resolved Hide resolved
border: 1px solid #5070a0;
border-radius: 3px;
background-color: #c9e1ff;
#WingMenuPlugin QWidget {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

background: #edeceb;
padding: 0px;
margin: 0px;
/* prevents unexpected borders/boxes on hover */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work. Showdesktop, colorpicker, main|fancymenu, quicklaunch items have now borders on hover, while some others don't (volume, mount, brightness).

@AzumaHazuki
Copy link
Contributor Author

Okay, I think we're ready :) Removed the Wing Menu stuff, did some serious cleaning up in there to lower the verbosity, and tightened a few things up. This should be good to go. I'll do similar for Leech next.

@stefonarch
Copy link
Member

Not all mentioned issues are addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants