Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lxqt-palette.conf for builtin themes #24

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antis81
Copy link

@antis81 antis81 commented Jan 10, 2021

Colors are based on the "Ambience" theme which served as reference for a dark theme.

Reference Screenshot:

theme-dark-sample

Note: The palettes don't have any effect until implementation in liblxqt is done.

Further steps:

  • liblxqt should fallback to a default palette (see lxqt-config-appearance -> defaultPalette()) if no lxqt-palette.conf file is provided by a theme.
    (especially important for "third-party" themes like e.g. "ArcMaia")

Builtin "dark" themes TBD:

  • kvantum (dark theme?)

Builtin "light" themes TBD:

  • light
  • kde-plasma (light theme)
  • clearlooks (light theme)

Special cases:

  • system (not an LXQt theme)

Colors are based on the "Ambience" theme as template.
@antis81 antis81 changed the title add lxqt-palette.conf for known dark themes add lxqt-palette.conf for builtin themes Jan 10, 2021
@tsujan
Copy link
Member

tsujan commented Jan 10, 2021

These files don't have any meaning yet and this PR shouldn't be merged. So, I'm converting it to a draft.

You first need to give them meaning by writing code for lxqt-config. Then, this could be changed to a PR again.

@tsujan tsujan marked this pull request as draft January 10, 2021 14:40
@antis81
Copy link
Author

antis81 commented Jan 11, 2021

These files don't have any meaning yet and this PR shouldn't be merged. So, I'm converting it to a draft. …

Sure, the topic actually spreads across these four LXQt modules:

  • lxqt-theme
  • lxqt-config-appearance
  • lxqt-qtplugin (QPalette becomes effective here at runtime; no code modification needed now!)
  • liblxqt (holds LXQtTheme singleton)

By moving the context completely to lxqt-qtplugin (take it as in "QWidget support") at the very least the liblxqt dependency can be resolved and vanishes. However this is maybe for a mid-term goal (milestone?)…

@tsujan
Copy link
Member

tsujan commented Jan 11, 2021

By moving the context completely to lxqt-qtplugin

No, lxqt-qtplugin doesn't need to be touched for this. As said before, applying palettes is only related to lxqt-config; no other component should be cluttered.

@tsujan
Copy link
Member

tsujan commented Jan 11, 2021

Let me explain it again:

The logic is as simple as this: Appropriately add code to lxqt-config for optionally applying ready-made palettes consisting of 8 colors that we support.

lxqt-config can already apply 8-color palettes by writing to ~/.config/lxqt/lxqt.conf. This is just about reading those 8 colors from specific files inside lxqt-themes — like the files you've added here — nothing more.

@stefonarch
Copy link
Member

If I get it right - as we have now palettes corresponding to the dark themes - just a checkbox "Apply suitable palette colors" under the wallpaper checkbox would do.

@stefonarch
Copy link
Member

@tsujan Any thought about implementing this checkbox of above for 1.3?

@tsujan
Copy link
Member

tsujan commented Nov 20, 2022

Any thought about implementing this checkbox of above for 1.3?

It could be done.

To me, porting LXQt to Qt6 has priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants