Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the custom tab name behavior #678

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance the custom tab name behavior #678

wants to merge 2 commits into from

Conversation

chrcuray
Copy link
Contributor

Modify custom tab name behavior:

  • use available session name during session edit (was empty)
  • restoring to terminal title when custom name is empty (was not possible)

@chrcuray chrcuray changed the title Modify custom tab name behavior Enhance the custom tab name behavior May 28, 2020
@chrcuray chrcuray mentioned this pull request Oct 29, 2020
Open
@yan12125 yan12125 mentioned this pull request May 24, 2022
Closed
@yan12125
Copy link
Member

Sorry for the long delay. Overall this looks good. There is one minor issue: when there isn't any custom tab name yet, using an empty string in the "Tab name" dialog makes the tab name empty. Probably better to keep the current tab name (i.e., do nothing) in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feedback required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrcuray @yan12125