Fixing shadow.py to add more than 1 KeyCredential object and correctly list them #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this PR makes allows to set multiple KeyCredential objects for the same account (certipy currently overwrites the existing one) and allows properly listing them (which seemed to be faulty before).
Before:
Powerview.py can successfully read them:
After:
This can be very useful when performing abusing GenericWrite/All privileges against an object that has the msDS-KeyCredentialLink already populated as it prevents attribute overwrites and then allows retrieving the device-id for easy removal.