Fixed Certificate Names with Slashes or Paratheses #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeLauterbach
changed the title
|
Hi ! >>> from ldap3.utils.conv import escape_filter_chars
>>> escape_filter_chars("Hello (World?)")
'Hello \\28World?\\29'
>>> As ldap3 is already a certipy dependency, I think it should be used. 🌻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, certificate names with paratheses would cause the LDAP search to fail with error
malformed error. This change properly formats the template name to avoid LDAP search failures.Semi-related, but this also fixes errors that would be caused when attempting to save the configuration of templates with slashes in the name (as reported in #213).