Added extended rights to 'find' command. Smaller changes to has_vulne… #226
+48
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rable_acl function in 'find'
|
I have verified that this indeed does fix ESC1 false-positive in my current target. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there were false positive instances of ESC1, showing enrollment rights for users that were not able to enroll in those templates.
Looking at the ACEs it turned out the the 'Enroll' permission was indeed assigned to the principal, but the
ACTIVE_DIRECTORY_RIGHTS.EXTENDED_RIGHTwas not, which prevented enrollment.Certify has the same permission check implemented here.
While adjusting the code I also changed the "write permissions" view to show which specific write permissions a principal has, but only report the write permission as ESC4 if the entire template can be modified.