Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up steps in action #248

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Split up steps in action #248

merged 5 commits into from
Oct 7, 2024

Conversation

mre
Copy link
Member

@mre mre commented Oct 7, 2024 •
edited
Loading

This helps with making the code more debuggable/maintainable.
I tried to stay as close as possible to the original logic, but made the individual steps smaller.

@mre
Copy link
Member Author

mre commented Oct 7, 2024

@sebastiaanspeck, does this look good to you?
I made these changes because I couldn't see the issue in #247. After my PR gets merged, that should be easier to do (also in the future). You will have to rebase your PR on top of master for that.

@mre mre mentioned this pull request Oct 7, 2024
Merged
@mre mre merged commit e71a9a1 into master Oct 7, 2024
4 checks passed
@mre mre deleted the refactor-action-steps branch October 7, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mre @sebastiaanspeck