Harmonizes naming pattern of pre-built binaries and unlocks latest permalink #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The test fails seem to be unrelated to my changes. Their implementation contains remarks about flakyness. Maybe increasing the number of re-tries or adding a delay in between would help to reduce the ci-noise. |
removes tag names to unlock latest-permalink
changes macos and windows release assets to follow linux naming scheme: lychee-{cpu}-{platform}.{ext}
mre
force-pushed
the
unlock-latest-permalink
branch
from
d0d0afe
to
3f00c2a
Compare
|
Thanks @axel-kah! The code looks fine. I didn't find a great way to test it, but we'll give it a shot with the next release. 👍 |
|
Sweet! Any idea when that will be (ballpark)? |
dscho
added a commit
to dscho/lychee-action
that referenced
this pull request
Aug 12, 2024
The name of the `.tar` file is repeated multiple times, verbatim. This not only violates the Don't Repeat Yourself (DRY) principle, it also makes it easier to miss an instance when the file name changes (as it did with lycheeverse/lychee#1464). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/lychee-action
that referenced
this pull request
Aug 12, 2024
Until version 0.15.1, the naming scheme of the release assets let them start with `lychee-<version>-`. This is no longer the case as of lycheeverse/lychee#1464, though, breaking the `lychee-action`. Since we need to allow using older versions, still, we are now stuck with a really ugly `case` construct, but this is still far better than having a broken GitHub Action. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/lychee-action
that referenced
this pull request
Aug 12, 2024
The name of the `.tar` file is repeated multiple times, verbatim. This not only violates the Don't Repeat Yourself (DRY) principle, it also makes it easier to miss an instance when the file name changes (as it did with lycheeverse/lychee#1464). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/lychee-action
that referenced
this pull request
Aug 12, 2024
Until version 0.15.1, the naming scheme of the release assets let them start with `lychee-<version>-`. This is no longer the case as of lycheeverse/lychee#1464, though, breaking the `lychee-action`. Since we need to allow using older versions, still, we are now stuck with a really ugly `case` construct, but this is still far better than having a broken GitHub Action. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/lychee-action
that referenced
this pull request
Aug 12, 2024
Until version 0.15.1, the naming scheme of the release assets let them start with `lychee-<version>-`. This is no longer the case as of lycheeverse/lychee#1464, though, breaking the `lychee-action`. Since we need to allow using older versions, still, we are now stuck with a really ugly `case` construct, but this is still far better than having a broken GitHub Action. Signed-off-by: Johannes Schindelin <[email protected]>
|
We got some issues with the change. Follow lycheeverse/lychee-action#232 and lycheeverse/lychee-action#234 for updates. |
mre
pushed a commit
to lycheeverse/lychee-action
that referenced
this pull request
Aug 20, 2024
Work around new naming scheme Until version 0.15.1, the naming scheme of the release assets let them start with `lychee-<version>-`. This is no longer the case as of lycheeverse/lychee#1464, though, breaking the `lychee-action`. Since we need to allow using older versions, still, we are now stuck with a really ugly `case` construct, but this is still far better than having a broken GitHub Action. The name of the `.tar` file is repeated multiple times, verbatim. This not only violates the Don't Repeat Yourself (DRY) principle, it also makes it easier to miss an instance when the file name changes (as it did with lycheeverse/lychee#1464). DRY up the lengthy `.tar` file name. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1463