Add release-plz and clean up workflows #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's no secret that we're lacking behind on releases; partially, because they are slightly tedious to create. My hope is that this will be resolved by introducing `release-plz` [1], which is automates publication whenever we push to `master`. Along the way, I aligned the naming of the other workflows. [1]: https://github.com/MarcoIeni/release-plz
|
The failing |
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
I don't think we have a main branch currently. Do you plan to rename the master branch?
There was a problem hiding this comment.
That's the goal -- eventually. But for now it would work with both, main and master, which will make that transition easier in the future.
|
@mre Sounds like a great idea! How does it affect the failing Docker image build? |
|
I think it will publish release binaries under the new binary names, so that should automatically fix the Docker build. At least that's my current working theory. 🙃 |
|
Ah okay sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no secret that we're lacking behind on releases; partially, because they are slightly tedious to create.
My hope is that this will be resolved by introducing
release-plz1, which is automates publication whenever we push tomaster.Along the way, I aligned the naming of the other workflows.