-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix point calculation for twoWayOffset due to wrong angle direction #53
base: main
Are you sure you want to change the base?
Conversation
cbd30a2
to
ecbe2ae
Compare
@keith @gabriellanata Added GitHub Actions fixes |
b089718
to
4404c8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i'm a little confused on what this fixes. Seems like its working correctly right now: See the HandTests.testViewRotationGesture()
test. The view rotates as expected. Are you specifying degrees or radians when trying to use this function?
@gabriellanata It is the fix for let angle = -35 * (Double.pi / 180.0)
try eventGenerator.fingerPinch(fromDistance: 20, toDistance: 200, angle: angle, duration: 3) |
@gabriellanata are you still confident that it's not an issue? |
This PR address incorrect calculation for a
twoWayOffset
function. Expected behaviour (I guess) was to have two touches with 180° with configurable angle to the horizont.After PR
fix.angle.mov
Before
Here is how it looks like for angle = 0:
horizontal.mov
And this is what we have for a 35 degrees angle:
angle.mov