Switch to Xcode 15.4 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillyakimovich
force-pushed
the
xcode-15-4
branch
from
e236d03
to
806ebcd
Compare
kirillyakimovich
force-pushed
the
xcode-15-4
branch
from
806ebcd
to
7e613eb
Compare
marcosgriselli
force-pushed
the
xcode-15-4
branch
from
3ff8513
to
f52f589
Compare
| -destination "name=iPhone 6" \ | ||
| test | ||
| -destination "name=iPhone 11" \ | ||
| -sdk iphonesimulator15.0 \ |
There was a problem hiding this comment.
This a bit unfortunate but GitHub Actions deprecated the macos_11 runner which would let us test all the way to iOS 13.7. We can figure out alternatives if this is critical but we'd need to download and install a large runtime file.
There was a problem hiding this comment.
I think this is fine
Comment on lines
-14
to
-19
| - name: List available Xcode versions | ||
| run: ls /Applications | grep Xcode | ||
| - name: Force Xcode 12.4 | ||
| run: sudo xcode-select -switch /Applications/Xcode_12.4.app | ||
| - name: List available simulators | ||
| run: xcrun simctl list |
There was a problem hiding this comment.
Removed these since that information is out in each runner: https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md
| @@ -1,5 +1,9 @@ | |||
| .DEFAULT_GOAL := generate | |||
|
|
|||
| # Code Signing Settings | |||
|
|
|||
| NO_CODE_SIGN_SETTINGS = CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | |||
There was a problem hiding this comment.
Nice! I was trying to do that in different place fa673da
Thank you!
gabriellanata
previously approved these changes
Jun 12, 2024
gabriellanata
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 12.4 is not available anymore